This repository has been archived by the owner on Jun 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove unneeded strict-mode related methods
This commit removes 3 exported methods relating to strict-mode detection: * Instance.StrictModeCompliant * Flavor.HasInnoFileFormat * Flavor.InnoRowFormatReqs Skeema v1.5.0 no longer enforces, requires, or assumes use of strict mode, so these methods no longer have a caller, and there are no known third-party open source callers of these methods. They're rather niche, and Instance.StrictModeCompliant wasn't sufficiently thorough to fully solve its intended use anyway. Additionally, now that MySQL 5.6 has reached its support EOL date by Oracle, strict mode is enabled by default in all non-EOL versions of MySQL and MariaDB. This is a backwards-incompatible change; this package is still pre-1.0. Even so, removal of exported methods is typically avoided, but in this case the benefits of complexity reduction and faster test execution outweigh keeping around the dead weight of unused code.
- Loading branch information
Showing
4 changed files
with
0 additions
and
281 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters