Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hafasreader.py #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

timetable2014
Copy link

Add some documentation about the hdrf

Add some documentation about the hdrf
@skinkie
Copy link
Owner

skinkie commented Apr 27, 2014

In general: please indent the # (hash) for the comments.

I don't know if its a good approach to polish this source at this moment. I am considering a rewrite with generalises the parsing based on the documentation.

@timetable2014
Copy link
Author

I try to give so more insights to the documentation.

@skinkie
Copy link
Owner

skinkie commented Apr 27, 2014

Guessing what the meaning could be was not the issue ;) But I am under the impression that the Haltestellennummer is actually not bahnhof here, but a mask.

@timetable2014
Copy link
Author

yes, it's a mask. the haltestellennummer starts with the UIC - Code. If you have a Haltestellennummer which is not in the zeitvs, you have to decrease the number of the haltestellennummer since you have a match in the list

@skinkie
Copy link
Owner

skinkie commented Apr 27, 2014

Could you maybe tell me if there are any other situations where this 'mask' situation applies? I would like to add the timezone to the GTFS stops.txt.

@timetable2014
Copy link
Author

I think for zeitvs there is no second mask

1100000 0000000 means, that all Station starting with 11 uses the same timezone as 00000000

@skinkie
Copy link
Owner

skinkie commented Apr 27, 2014

I was more thinking in terms of the format itself, situation where a join on haltestellennummer = bahnhof doesn't directly apply but the mask does

@timetable2014
Copy link
Author

I didn't understand the question. Are you looking for situations where this masking works in other files?

@skinkie
Copy link
Owner

skinkie commented Apr 27, 2014

Exactly.

@timetable2014
Copy link
Author

no, the masking is just in zeitvs. sometimes @@@@@@ is used indicating, that all stations have the same properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants