Merge pull request #25 from skiptomyliu/2018-12-20-hotfix

hotfix for transitions
skiptomyliu · Dec 21, 2018 · 81fd27b · 81fd27b
2 parents 1bc5280 + 979ef64
commit 81fd27b
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/App/Milkshake.dmg b/App/Milkshake.dmg
diff --git a/Milkshake.xcworkspace/xcuserdata/dean.xcuserdatad/UserInterfaceState.xcuserstate b/Milkshake.xcworkspace/xcuserdata/dean.xcuserdatad/UserInterfaceState.xcuserstate
diff --git a/Milkshake/Info.plist b/Milkshake/Info.plist
@@ -19,7 +19,7 @@
 	<key>CFBundleShortVersionString</key>
 	<string>1.0.5</string>
 	<key>CFBundleVersion</key>
-	<string>27</string>
+	<string>28</string>
 	<key>LSApplicationCategoryType</key>
 	<string>public.app-category.music</string>
 	<key>LSMinimumSystemVersion</key>

diff --git a/Milkshake/Music.swift b/Milkshake/Music.swift
@@ -66,7 +66,9 @@ class Music: NSObject {
             print("Music - URL: ", url)
             item.duration = Int(length)
             self.curPlayingItem = item
-            self.removeTimeObserver()
+            DispatchQueue.main.sync {
+                self.removeTimeObserver()
+            }
             DispatchQueue.main.async {
                 self._playAudio(playerItem: playerItem)
             }

diff --git a/Milkshake/PlayerViewController.swift b/Milkshake/PlayerViewController.swift
@@ -56,7 +56,7 @@ class PlayerViewController: NSViewController, MusicTimeProtocol {
         self.updateSliderTime(duration: duration, totalTime: totalTime)
         let timeLeft = totalTime - duration
 
-        if (timeLeft <= 10 && timeLeft > 0 && appDelegate.music?.crossFade == true) {
+        if (timeLeft <= 10 && appDelegate.music?.crossFade == true && appDelegate.music?.timeObserverToken != nil) {
             appDelegate.music?.removeTimeObserver()
             appDelegate.music?.playNext()
         }