forked from python/cpython
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imaginary type and IEC 60559-compatible complex arithmetic #1
Open
skirpichev
wants to merge
10
commits into
main
Choose a base branch
from
imaginary-class-109218
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
force-pushed
the
imaginary-class-109218
branch
2 times, most recently
from
May 25, 2024 13:45
7323971
to
99d1b8c
Compare
skirpichev
changed the title
gh-109218: Imaginary type and IEC 60559-compatible complex arithmetic
Imaginary type and IEC 60559-compatible complex arithmetic
Jun 9, 2024
skirpichev
force-pushed
the
imaginary-class-109218
branch
2 times, most recently
from
June 14, 2024 12:19
4db428d
to
6f13b24
Compare
skirpichev
force-pushed
the
imaginary-class-109218
branch
3 times, most recently
from
June 29, 2024 09:16
4ca3e9a
to
c114f16
Compare
skirpichev
pushed a commit
that referenced
this pull request
Jul 21, 2024
…ython#119498) (#1… (python#119905) Revert "[3.12] pythongh-69214: Fix fcntl.ioctl() request type (python#119498) (python#119505)" This reverts commit 078da88. The change modified how negative values, like termios.TIOCSWINSZ, was treated and is actually backward incompatible.
skirpichev
force-pushed
the
imaginary-class-109218
branch
from
July 25, 2024 07:51
36c6bf5
to
7e68e91
Compare
skirpichev
force-pushed
the
imaginary-class-109218
branch
from
August 3, 2024 07:19
6a44153
to
d605b8e
Compare
"Generally, mixed-mode arithmetic combining real and complex variables should be performed directly, not by first coercing the real to complex, lest the sign of zero be rendered uninformative; the same goes for combinations of pure imaginary quantities with complex variables." (c) Kahan, W: Branch cuts for complex elementary functions. That's why C standards since C99 introduce imaginary types. This patch proposes similar extension to the Python language: * Added a new subtype (imaginary) of the complex type. New type has few overloaded methods (conjugate() and __getnewargs__()). * Complex and imaginary types implement IEC 60559-compatible complex arithmetic (as specified by C11 Annex G). * Imaginary literals now produce instances of imaginary type. * cmath.infj/nanj were changed to be of imaginary type. * Modules ast, code, copy, marshal got support for imaginary type. * Few tests adapted to use complex, instead of imaginary literals - Lib/test/test_fractions.py - Lib/test/test_socket.py - Lib/test/test_str.py Lets consider some (actually interrelated) problems, shown for unpatched code, which could be solved on this way. 1) First, new code allows to use complex arithmetic for implementation of mathematical functions without special "corner cases". Take the inverse hyperbolic sine as an example: >>> z = complex(-0.0, 2) >>> cmath.asinh(z) (-1.3169578969248166+1.5707963267948966j) >>> # naive textbook formula doesn't work: >>> cmath.log(z + cmath.sqrt(1 + z*z)) (1.3169578969248166+1.5707963267948966j) >>> # "fixed" version does: >>> cmath.log(z + cmath.sqrt(complex(1 + (z*z).real, (z*z).imag))) (-1.3169578969248164+1.5707963267948966j) 2) Previously, we have only unsigned imaginary literals with the following semantics: ±a±bj = complex(±float(a), 0.0) ± complex(0.0, float(b)) While this behaviour was well documented, most users would expect instead here: ±a±bj = complex(±float(a), ±float(b)) i.e. that it follows to the rectangular notation for complex numbers. 3) The ``eval(repr(x)) == x`` invariant was broken for the complex type. Below are simple examples with signed zero: >>> complex(-0.0, 1.0) # also note funny signed integer zero below (-0+1j) >>> -0+1j 1j >> -(0.0-1j) # "correct" input for above with Python numeric literals (-0+1j) >>> -(0-1j) # also "correct"; integer 0 matters! (-0+1j) >>> complex(1.0, -0.0) (1-0j) >>> 1-0j (1+0j) >>> -(-1 + 0j) (1-0j) Similar is true for complex numbers with other special components: >>> complex(0.0, -cmath.inf) -infj >>> -cmath.infj (-0-infj)
>>> complex(-0.0, 1) # was (-0+1j) (-0.0+1j) This doesn't break complex(str(x)) == x invariant as we had support for parsing signed 0.0's here before.
* adapt Lib/test/test_format.py and Lib/test/test_complex.py * adjust doctests
skirpichev
force-pushed
the
imaginary-class-109218
branch
from
October 1, 2024 04:15
2c3d2b4
to
db12274
Compare
* more tests for multiplication * rename to _Py_convert_int_to_double * rename to real_to_float/complex * slightly optimize code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Generally, mixed-mode arithmetic combining real and complex variables should be performed directly, not by first coercing the real to complex, lest the sign of zero be rendered uninformative; the same goes for combinations of pure imaginary quantities with complex variables." (c) Kahan, W: Branch cuts for complex elementary functions.
That's why C standards since C99 introduce imaginary types. This patch proposes similar extension to the Python language:
__getnewargs__()
).Lets consider some (actually interrelated) problems, shown for unpatched code, which could be solved on this way.
While this behaviour was well documented, most users would expect instead here:
i.e. that it follows to the rectangular notation for complex numbers.
Things are worse, because the CPython docs sometimes asserts that the rectangular form is used and that some simple invariants holds. For example, sphinx docs for the complex class says: "complex(real=0, imag=0) ... Return a complex number with the value real + imag*1j ...". But:
eval(repr(x)) == x
invariant was broken for the complex type. Below are simple examples with signed zero:Similar was true for complex numbers with other special components:
See also ISO/IEC 9899:2011, Annex G and Rationale for C99 and Augmenting a Programming Language with Complex Arithmetic.
📚 Documentation preview 📚: https://cpython-previews--1.org.readthedocs.build/