Improve Django 1.9 support when using fine-uploader #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is removed in Django 1.9.
|
It's a little sad that this PR Is still not merged with the master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Django 1.9 the WSGIRequest.REQUEST property is removed (https://docs.djangoproject.com/en/1.9/releases/1.9/#features-removed-in-1-9).
This means that by default uploads will fail when using fine-uploader via django-ajax-uploader. I addressed this by adding a simple if statement to try POST before REQUEST.
Tested on Django 1.9.7.
(Thanks for this great project -- I searched for ages for something nice.)