Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of reauthentication flow #124

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

WebSpider
Copy link
Contributor

Reauthentication is triggered when initial login fails.
Needs real-world testing still

Copy link
Member

@dvx76 dvx76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending real-world test

@WebSpider WebSpider added the enhancement New feature or request label Nov 11, 2024
@WebSpider
Copy link
Contributor Author

Tested in real world. Functionally works, but gives this warning:

2024-11-14 01:13:34.584 WARNING (MainThread) [homeassistant.config_entries] Detected reauth config flow creating a new entry, when it is expected to update an existing entry and abort. This will stop working in 2025.11, please create a bug report at https://github.com/skodaconnect/homeassistant-myskoda/issues

@WebSpider
Copy link
Contributor Author

Gah, stupid linter.

@dvx76
Copy link
Member

dvx76 commented Dec 23, 2024

@WebSpider are you still working on this one?

@WebSpider
Copy link
Contributor Author

Hope to make some time for this over the holiday, but if you have something ready, dont let me stop you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants