Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove AuxiliaryHeating from partial update for CitigoE IV #491

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

prvakt
Copy link
Collaborator

@prvakt prvakt commented Dec 24, 2024

CitigoE IV doesnt have auxiliary heater as that's available only for ICE and PHEV vehicles

@prvakt prvakt requested a review from WebSpider December 24, 2024 10:27
@prvakt
Copy link
Collaborator Author

prvakt commented Dec 24, 2024

CitigoE IV doesnt have auxiliary heater as that's available only for ICE and PHEV vehicles

now I'm wondering why auxiliary-heating data was requested if car doesn't have this capability and also see from log that departure timer was requested as well.. looks like some Citigoes are not fulfilling this condition or something else is wrong

if (
  self.data.vehicle.info.device_platform == "MBB"
  and self.data.vehicle.info.specification.model == "CitigoE iV"
):

@WebSpider WebSpider added the bugfix This PR contains a bugfix label Dec 24, 2024
@prvakt
Copy link
Collaborator Author

prvakt commented Dec 24, 2024

CitigoE IV doesnt have auxiliary heater as that's available only for ICE and PHEV vehicles

now I'm wondering why auxiliary-heating data was requested if car doesn't have this capability and also see from log that departure timer was requested as well.. looks like some Citigoes are not fulfilling this condition or something else is wrong

if (
  self.data.vehicle.info.device_platform == "MBB"
  and self.data.vehicle.info.specification.model == "CitigoE iV"
):

Ahh I see, it requests the full data for the first time and then if Citigo is detected, it request partial data next time.. then still wondering why auxiliary-heating was requested if not in capability...

Switching to draft and will request fixtures from that car first..

@prvakt prvakt marked this pull request as draft December 24, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR contains a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants