Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1364 data grid review #1423

Merged
merged 40 commits into from
Sep 17, 2024
Merged

Feature/1364 data grid review #1423

merged 40 commits into from
Sep 17, 2024

Conversation

Diaan
Copy link
Collaborator

@Diaan Diaan commented Jul 22, 2024

No description provided.

@Diaan Diaan linked an issue Jul 22, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Jul 22, 2024

⚠️ No Changeset found

Latest commit: e8bf01b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Diaan
Copy link
Collaborator Author

Diaan commented Jul 22, 2024

Why does sorter.ts have so many inputs when you pass the entire column, that has all the properties that are needed?

Copy link
Contributor

github-actions bot commented Jul 22, 2024

🕸 Website preview

You can view a preview here (commit e8bf01bb540c6af7e6182b3bfe8049ca719a6294).

Copy link
Contributor

github-actions bot commented Jul 22, 2024

🕸 Storybook preview

You can view a preview here (commit e8bf01bb540c6af7e6182b3bfe8049ca719a6294).

@anna-lach anna-lach marked this pull request as ready for review August 29, 2024 07:12
packages/components/grid/index.ts Outdated Show resolved Hide resolved
packages/components/grid/register.ts Outdated Show resolved Hide resolved
packages/components/grid/src/column-group.ts Show resolved Hide resolved
packages/components/grid/src/column.spec.ts Outdated Show resolved Hide resolved
packages/components/grid/src/sort-column.ts Show resolved Hide resolved
packages/components/grid/src/sorter.spec.ts Outdated Show resolved Hide resolved
packages/components/grid/src/sorter.ts Outdated Show resolved Hide resolved
packages/components/grid/src/stories/basics.stories.ts Outdated Show resolved Hide resolved
packages/components/grid/src/view-model.ts Show resolved Hide resolved
@anna-lach anna-lach marked this pull request as draft September 11, 2024 06:38
@Diaan Diaan marked this pull request as ready for review September 16, 2024 11:57
@Diaan Diaan merged commit fc4791c into main Sep 17, 2024
13 checks passed
@Diaan Diaan deleted the feature/1364-data-grid-review branch September 17, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data grid] Review code that is already available
3 participants