Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1487 poc paginator component #1497

Draft
wants to merge 46 commits into
base: main
Choose a base branch
from
Draft

Feature/1487 poc paginator component #1497

wants to merge 46 commits into from

Conversation

anna-lach
Copy link
Collaborator

No description provided.

@anna-lach anna-lach linked an issue Sep 4, 2024 that may be closed by this pull request
[PoC] Paginator component #1487
Open
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f6f9fde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024 •
edited
Loading

🕸 Website preview

You can view a preview here (commit f6f9fde7c04c80652b7a81df178b7e0b52ef0b84).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024 •
edited
Loading

🕸 Storybook preview

You can view a preview here (commit f6f9fde7c04c80652b7a81df178b7e0b52ef0b84).

@anna-lach
some paginator styling changes
e0110c2
@anna-lach
paginator structure changes, first version of links
1fa9cca
@anna-lach
paginator with link, stories improvements, styling changes
a7d3727
@anna-lach
Merge remote-tracking branch 'origin/main' into feature/1487-POC-pagi…
b4d179e 
…nator-component
@anna-lach
previous and next buttons without labels (only aria-labels) - arrows …
be9a6b5 
…only, initially added a menu and menu button
@anna-lach
overflow version with menu button
095f01e
@anna-lach
first part of truncation, removed for now links stories
d91843d
@anna-lach
links variant removed - with navigation property, overflow changes, p…
2c2bd46 
…artially hiding pages
@anna-lach
Merge remote-tracking branch 'origin/main' into feature/1487-POC-pagi…
dc9df74 
…nator-component
@anna-lach
Merge remote-tracking branch 'origin/main' into feature/1487-POC-pagi…
02461fe 
…nator-component
@anna-lach
new files for separated parts of the component, truncation working on…
a232e59 
… the right, when the first part of the left is selected, adding proper menu items
@anna-lach
ellipsis for the last page on the overflow variant, partially added a…
5de91d3 
…lgorithm for the middle variant, in progress
@anna-lach
working truncation, partially added mobile variant with select only -…
04a00ea 
… only working in some cases for now
@anna-lach
Merge remote-tracking branch 'origin/main' into feature/1487-POC-pagi…
011f38d 
…nator-component
@anna-lach
improved responsiveness - mobile version, some styling changes
fdacdc3
@anna-lach
removed unnecessary dependency
ebd9189
@anna-lach
Merge remote-tracking branch 'origin/main' into feature/1487-POC-pagi…
deab17f 
…nator-component
anna-lach and others added 20 commits September 24, 2024 16:11
@anna-lach
improved responsiveness for the first and last part, still buggy in t…
d9f00e5 
…he middle part, improved checking the initial menu button width (moreButton)
@anna-lach
Merge remote-tracking branch 'origin/main' into feature/1487-POC-pagi…
0b25730 
…nator-component
@anna-lach
improved responsiveness, first version of pageSize component, missing…
b7f0863 
… event for activePage change
@anna-lach
visible items component, stories changes and new stories partially ad…
5637bda 
…ded, page size and paginator changes
@anna-lach
story with cards improvements
af44c6a
@anna-lach
visible items component, page size component and paginator changes
8f57d01
@anna-lach
mobile story, new icons used, mobile and desktop variant improvements…
4b862c5 
…, added missing refenece in the tsconfig and other changes
@anna-lach
Merge remote-tracking branch 'origin/main' into feature/1487-POC-pagi…
5586ea3 
…nator-component
@anna-lach
changes in the mobile and desktop versions
45e4f39
@anna-lach
improved mobile variant
69102de
@anna-lach
added missing dependencies, example story of grid with paginator and …
63dcec5 
…filter, data source with pagination, some styling changes
@anna-lach
Merge remote-tracking branch 'origin/main' into feature/1487-POC-pagi…
5efd486 
…nator-component
@anna-lach
data source changes, paginator with data grid and filtering, sorting …
8d1d81d 
…stories, some other paginator and subcomponents changes
@anna-lach
Merge remote-tracking branch 'origin/main' into feature/1487-POC-pagi…
9fac037 
…nator-component
@arecuenco-dsgn
New Min-Width token for the paginator button page
8496800
@anna-lach
new token for paginator page button min width, new ellipsis down icon
65b75fb
@anna-lach
new ellipsis-down icon
95940ac
@anna-lach
new page component with custom button, partially styled with tokens, …
2c96591 
…renamed visible items to items counter to allign with figma, new ellipsis icon used, paginator responsiveness improved
@anna-lach
Merge remote-tracking branch 'origin/main' into feature/1487-POC-pagi…
f6400a9 
…nator-component
@anna-lach
paginator and items counter refactor, fixing bugs, currently visible …
f6f9fde 
…items and other changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Diaan Diaan Awaiting requested review from Diaan Diaan will be requested when the pull request is marked ready for review Diaan is a code owner

@jpzwarte jpzwarte Awaiting requested review from jpzwarte jpzwarte will be requested when the pull request is marked ready for review jpzwarte is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PoC] Paginator component
2 participants
@anna-lach @arecuenco-dsgn