-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve naming of contextual CSS custom properties #1510
Conversation
🦋 Changeset detectedLatest commit: 0066a17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🕸 Website previewYou can view a preview here (commit |
🕸 Storybook previewYou can view a preview here (commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @Diaan can also take w look? :)
As discussed, for contextual tokens we want to use the following naming convention:
--sl-[a-z][a-zA-Z]*(-[a-z][a-zA-Z]*)*
This PR changes the
build-themes.js
to apply this transformation to the following files:All the other JSON files still use the old everyting-is-kebab-case convention.