Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking a label doesn't always focus the form control #1536

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

jpzwarte
Copy link
Member

Fixes #1514

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: 1b0e79f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sl-design-system/radio-group Patch
@sl-design-system/combobox Patch
@sl-design-system/select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 23, 2024

🕸 Website preview

You can view a preview here (commit 1b0e79fe7c162dbbc868073cdd9f01ddb1320661).

Copy link
Contributor

github-actions bot commented Sep 23, 2024

🕸 Storybook preview

You can view a preview here (commit 1b0e79fe7c162dbbc868073cdd9f01ddb1320661).

Copy link
Collaborator

@anna-lach anna-lach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @Diaan's review as well :)

@jpzwarte jpzwarte merged commit d79c397 into main Sep 23, 2024
9 of 13 checks passed
@jpzwarte jpzwarte deleted the fix/1514-label-doesnt-always-focus-form-control branch September 23, 2024 09:33
@github-actions github-actions bot mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[form-field] Clicking a label does not always focus the form control
3 participants