Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a message when there are no filter matches in combobox #1539

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

jpzwarte
Copy link
Member

Fixed #1537

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: 5895163

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sl-design-system/combobox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 23, 2024

🕸 Website preview

You can view a preview here (commit 58951635fe0d353f1eef1105f29b56494b6e4167).

Copy link
Contributor

github-actions bot commented Sep 23, 2024

🕸 Storybook preview

You can view a preview here (commit 58951635fe0d353f1eef1105f29b56494b6e4167).

packages/components/combobox/src/combobox.ts Outdated Show resolved Hide resolved
@jpzwarte jpzwarte merged commit 48cd7d6 into main Sep 23, 2024
7 checks passed
@jpzwarte jpzwarte deleted the feature/1537-add-no-items-found-message branch September 23, 2024 13:59
@github-actions github-actions bot mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[combobox] Show a message when there are no results when filtering
3 participants