Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-label to icon only menu button stories #1541

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Add aria-label to icon only menu button stories #1541

merged 4 commits into from
Sep 23, 2024

Conversation

jpzwarte
Copy link
Member

Fixes #1511

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 383d0f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

🕸 Website preview

You can view a preview here (commit 383d0f8c5e50d6d87cae866127363e4e686c5076).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

🕸 Storybook preview

You can view a preview here (commit 383d0f8c5e50d6d87cae866127363e4e686c5076).

@jpzwarte jpzwarte changed the title Add label property to menu button, which set's the aria-label on the button Add aria-label to icon only menu button stories Sep 23, 2024
@jpzwarte jpzwarte merged commit e88c0e3 into main Sep 23, 2024
9 of 13 checks passed
@jpzwarte jpzwarte deleted the fix/1511-add-label-property-to-menu-button branch September 23, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anna-lach anna-lach anna-lach left review comments

@Diaan Diaan Diaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[menu-button] Missing aria-label attributes on icon only stories
3 participants
@jpzwarte @Diaan @anna-lach