Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data source improvements #1575

Merged
merged 31 commits into from
Oct 7, 2024
Merged

Data source improvements #1575

merged 31 commits into from
Oct 7, 2024

Conversation

jpzwarte
Copy link
Member

@jpzwarte jpzwarte commented Oct 4, 2024

  • Moved DataSource and ArrayDataSource into its own @sl-design-system/data-source package
  • Added FetchDataSource to the data source package
  • Removed the filteredItems property of DataSource (just use the items property instead)
  • Fixed ArrayDataSource to handle multiple filters for the same path using OR instead of AND
  • Changed GridColumn to render an <sl-skeleton> for items that equal FetchDataSourcePlaceholder

Fixes #140

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: ffbb1aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@sl-design-system/data-source Patch
@sl-design-system/shared Minor
@sl-design-system/grid Minor
@sl-design-system/accordion Patch
@sl-design-system/avatar Patch
@sl-design-system/button Patch
@sl-design-system/checkbox Patch
@sl-design-system/dialog Patch
@sl-design-system/editor Patch
@sl-design-system/emoji Patch
@sl-design-system/form Patch
@sl-design-system/format-date Patch
@sl-design-system/inline-message Patch
@sl-design-system/menu Patch
@sl-design-system/panel Patch
@sl-design-system/popover Patch
@sl-design-system/radio-group Patch
@sl-design-system/search-field Patch
@sl-design-system/select Patch
@sl-design-system/switch Patch
@sl-design-system/tabs Patch
@sl-design-system/tag Patch
@sl-design-system/text-area Patch
@sl-design-system/text-field Patch
@sl-design-system/toggle-button Patch
@sl-design-system/toggle-group Patch
@sl-design-system/tooltip Patch
@sl-design-system/combobox Patch
@sl-design-system/tool-bar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 4, 2024

🕸 Website preview

You can view a preview here (commit ffbb1aa6f20ef2f2bc8ca2a75a53c4b754c6eedf).

Copy link
Contributor

github-actions bot commented Oct 4, 2024

🕸 Storybook preview

You can view a preview here (commit ffbb1aa6f20ef2f2bc8ca2a75a53c4b754c6eedf).

@jpzwarte jpzwarte marked this pull request as ready for review October 4, 2024 11:50
@jpzwarte jpzwarte merged commit ebe4c8a into main Oct 7, 2024
9 of 13 checks passed
@jpzwarte jpzwarte deleted the feature/data-source-improvements branch October 7, 2024 09:04
@github-actions github-actions bot mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Development] Add grid example with data from back-end
3 participants