Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve form integration #1580

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jpzwarte
Copy link
Member

@jpzwarte jpzwarte commented Oct 8, 2024

  • Implement reset & submit behavior in <button> when there is only an <sl-form> parent present
  • Implement submit behavior in <sl-text-field> when there is only an <sl-form> parent present
  • Add sl-reset and sl-submit events on <sl-form>
  • Fix bug where resetting a form did not clear the validation messages
  • Add closestElementComposed utility method to shared package

Fixes #1566

Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: 75bf152

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 8, 2024

🕸 Website preview

You can view a preview here (commit 75bf15219d41da35d62d42a3fbd333073e1c1609).

Copy link
Contributor

github-actions bot commented Oct 8, 2024

🕸 Storybook preview

You can view a preview here (commit 75bf15219d41da35d62d42a3fbd333073e1c1609).

@jpzwarte jpzwarte marked this pull request as ready for review October 8, 2024 13:23
Copy link
Collaborator

@anna-lach anna-lach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add changeset? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Form] Submit by pressing Enter
3 participants