-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove eslint, use biome. #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! I had to resist hype for each change, but each line changed is solid 👏 Perhaps you know that 😉
Also, hello biome!! 👋 🌲
"build": "tsc", | ||
"start": "npm run build && node ./dist/app.js", | ||
"lint": "npx @biomejs/biome check --write *.ts", | ||
"test": "npm run build && npm run lint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So many great additions beyond biome here! 🎉
"@typescript-eslint/eslint-plugin": "^7.4.0", | ||
"@typescript-eslint/parser": "^7.4.0", | ||
"eslint": "~8.57.0", | ||
"eslint-config-airbnb-base": "~15.0.0", | ||
"eslint-config-airbnb-typescript": "^18.0.0", | ||
"eslint-plugin-import": "~2.29.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫡
@@ -1,141 +1,182 @@ | |||
{ | |||
"name": "bolt-ts-starter-template", | |||
"version": "1.0.0", | |||
"lockfileVersion": 1, | |||
"lockfileVersion": 3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweeeeet 🚀 This is such a welcomed version bump!
We could also change the name here and in package.json
to bolt-ts-custom-function-template
IMO but it's no blocker at all
@@ -1,4 +1,4 @@ | |||
import { App, BlockAction, LogLevel } from '@slack/bolt'; | |||
import { App, type BlockAction, LogLevel } from '@slack/bolt'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👨🍳 🤌 just a pinch of BlockAction
here
Removes eslint, uses biome. Our node-slack-sdk and bolt-js have moved to this tool (much faster, less dependencies).
Also adds node 22 to CI