-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1622 Additional check for exceptions from aiohttp #1632
Conversation
Try to avoid internal exceptions from aiohttp in `message_data`
Thanks for the contribution! Before we can merge this, we need @lingfish to sign the Salesforce Inc. Contributor License Agreement. |
Attempted signing of the CLA, got this: Could not sign the CLA, please contact: oss-bots@salesforce.com |
Sorry for the error. Closing and reopening this PR resolved the issue (I know this is not great but this is the workaround we're aware so far). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me; once the CI builds pass, we will merge it within a few business days
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1632 +/- ##
==========================================
- Coverage 85.06% 85.03% -0.04%
==========================================
Files 113 113
Lines 12658 12658
==========================================
- Hits 10768 10764 -4
- Misses 1890 1894 +4 ☔ View full report in Codecov by Sentry. |
Try to avoid internal exceptions from aiohttp in
message_data
Summary
Fix for #1622
Testing
I couldn't figure out a way to unit test for this, and the integration tests were over my head.
Category
/docs
(Documents)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.