-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made necessary changes #34
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Anuhav, thanks for the PR. These however were not the changes which were referenced by the issues
#28 - If you hover over the logo in the footer there's a thin border which appears which needs to be removed, the other borders need to stay in place
#31 - It was an animated border or a splash effect which I had in mind to appear on button hover, not a scale effect. The reason as to why I didn't mention it in detail within the issue was since I self assigned it.
#26 - The logo animation should be a rotation on the clock hand, again not a scale.
Also let's try and adhere to the commit message convention as referenced here
If it's possible for you to accommodate these, it'll be my pleasure, or if you could just leave out the redirections you added we'll be good to go and merge this in
I'll go with the latter |
No worries, and once again, thank you for the PR |
my pleasure |
Made the following changes: