Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made necessary changes #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

anubhav1206
Copy link
Contributor

Made the following changes:

  1. Added hover animation to footer buttons and TimeKeeper logo
  2. Added link to the gituhub button and sliitfoss.org button
  3. removed the footer dashed border

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

PR Preview Action 5a76da9d9b4f3c9f9f38a874675d91ad8fee3a3f
🛫 Deployed preview to https://timekeeper.sliitfoss.org/preview/pr-34/
on branch gh-pages at 2023-07-04 06:07 UTC

Copy link
Member

@Akalanka47000 Akalanka47000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Anuhav, thanks for the PR. These however were not the changes which were referenced by the issues

#28 - If you hover over the logo in the footer there's a thin border which appears which needs to be removed, the other borders need to stay in place

#31 - It was an animated border or a splash effect which I had in mind to appear on button hover, not a scale effect. The reason as to why I didn't mention it in detail within the issue was since I self assigned it.

#26 - The logo animation should be a rotation on the clock hand, again not a scale.

Also let's try and adhere to the commit message convention as referenced here

If it's possible for you to accommodate these, it'll be my pleasure, or if you could just leave out the redirections you added we'll be good to go and merge this in

@anubhav1206
Copy link
Contributor Author

Hello Anuhav, thanks for the PR. These however were not the changes which were referenced by the issues

#28 - If you hover over the logo in the footer there's a thin border which appears which needs to be removed, the other borders need to stay in place

#31 - It was an animated border or a splash effect which I had in mind to appear on button hover, not a scale effect. The reason as to why I didn't mention it in detail within the issue was since I self assigned it.

#26 - The logo animation should be a rotation on the clock hand, again not a scale.

Also let's try and adhere to the commit message convention as referenced here

If it's possible for you to accommodate these, it'll be my pleasure, or if you could just leave out the redirections you added we'll be good to go and merge this in

I'll go with the latter

@Akalanka47000
Copy link
Member

Hello Anuhav, thanks for the PR. These however were not the changes which were referenced by the issues
#28 - If you hover over the logo in the footer there's a thin border which appears which needs to be removed, the other borders need to stay in place
#31 - It was an animated border or a splash effect which I had in mind to appear on button hover, not a scale effect. The reason as to why I didn't mention it in detail within the issue was since I self assigned it.
#26 - The logo animation should be a rotation on the clock hand, again not a scale.
Also let's try and adhere to the commit message convention as referenced here
If it's possible for you to accommodate these, it'll be my pleasure, or if you could just leave out the redirections you added we'll be good to go and merge this in

I'll go with the latter

No worries, and once again, thank you for the PR

@anubhav1206
Copy link
Contributor Author

Hello Anuhav, thanks for the PR. These however were not the changes which were referenced by the issues
#28 - If you hover over the logo in the footer there's a thin border which appears which needs to be removed, the other borders need to stay in place
#31 - It was an animated border or a splash effect which I had in mind to appear on button hover, not a scale effect. The reason as to why I didn't mention it in detail within the issue was since I self assigned it.
#26 - The logo animation should be a rotation on the clock hand, again not a scale.
Also let's try and adhere to the commit message convention as referenced here
If it's possible for you to accommodate these, it'll be my pleasure, or if you could just leave out the redirections you added we'll be good to go and merge this in

I'll go with the latter

No worries, and once again, thank you for the PR

my pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants