Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: navbar #10

Merged
merged 15 commits into from
Dec 23, 2024
Merged

feat: navbar #10

merged 15 commits into from
Dec 23, 2024

Conversation

IT21182914
Copy link

No description provided.

@pawan-live pawan-live changed the title Feature/navbar feat: navbar Dec 23, 2024
@pawan-live
Copy link
Collaborator

@sathninduk please do a a review on this

@pawan-live
Copy link
Collaborator

I tested the functinonality, it seems to work fine, but the navbar dropdown is not as in the design, but I think we can accept that since it looks better than what was in the design 😄
image

And the language menu was also implemented, let's style that in a later task
image

Will add the other stuff separately

@pawan-live
Copy link
Collaborator

Thanks @IT21182914 for taking your time on contributing! 🙌

Shall we use nNext google fonts rather than local fonts? With that we can introduce DM Sans which was the font used in the design

Also is it possible to update the button to match the specs in the design?

image
image

Don't style the language select menu, keep it as it is, we'll update it on a later task.

@pawan-live pawan-live linked an issue Dec 23, 2024 that may be closed by this pull request
5 tasks
Copy link
Collaborator

@pawan-live pawan-live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things, will address them later

package.json Show resolved Hide resolved
src/app/layout.tsx Show resolved Hide resolved
@pawan-live pawan-live merged commit c7189ea into sliitsesc:develop Dec 23, 2024
@pawan-live pawan-live mentioned this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the navbar component
4 participants