-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use one set of Docker instruction name constants when processing Docker instruction/command info #374
Comments
Hey @kcq, I want to work on this, also I am very new to the project can you please drop me a few resources from where I can learn and contribute? |
Hi @kcq, @iximiuz go through this codebase you explained - https://www.youtube.com/watch?v=ioIG-oPg0pA The issue seems like when minifying the docker image need to provide a set of docker instructions/commands about images and containers similar to prompts? |
It's not limited to minifying images. There are several places in the code where the container instruction metadata is processed and those places use their own set of constants. For example: https://github.com/slimtoolkit/slim/blob/master/pkg/docker/instruction/instruction.go#L9 https://github.com/slimtoolkit/slim/blob/master/pkg/docker/dockerfile/dockerfile.go#L19 https://github.com/slimtoolkit/slim/blob/master/pkg/docker/dockerfile/reverse/reverse.go#L107 |
Okay. Thanks for sharing the links Kyle. Can you share more details on the above code and what exactly needs to be done? |
Hey @kcq, 1st approach -This can be done by creating new
And code in the spec map update to use constants from the enum. For example -
How's this approach IMO? 2nd approach -we can create a new constant
|
Hey @kcq should I go ahead with this ? |
Hi @kcq I am researching various approaches to meet the end goal. |
No description provided.
The text was updated successfully, but these errors were encountered: