You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -537,6 +537,30 @@ The `--dockerfile` option makes it possible to build a new minified image direct
The `--use-local-mounts` option is used to choose how the `docker-slim` sensor is added to the target container and how the sensor artifacts are delivered back to the master. If you enable this option you'll get the original `docker-slim` behavior where it uses local file system volume mounts to add the sensor executable and to extract the artifacts from the target container. This option doesn't always work as expected in the dockerized environment where `docker-slim` itself is running in a Docker container. When this option is disabled (default behavior) then a separate Docker volume is used to mount the sensor and the sensor artifacts are explicitly copied from the target container.
The reason will be displayed to describe this comment to others. Learn more.
It is worth noting that the report will only report on the host platform's build. Are there any other caveats or edge cases you can think of that are worth noting here @kcq?
Still issues on M1 builds @gthomson31 until we have this fully integrated try using the --image-build-engine and potentially --image-build-arch flags. With --image-build-engine=internal Slim will build the output image without using Docker, which might handle the same use case here (building optimized images on non-native platforms). If the target image's architecture isn't picked up properly the --image-build-arch flag should allow you to set it explicitly.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
estroz
force-pushed
the
feat/buildx-plugin
branch
from
Fixes #312
Supersedes #314 , which adds ~14 MB to the binary and a few new deps while this only adds ~3 MB and one new dep.
What
Leverage
docker buildxfor multi-platform output image buildsWhy
See #312
How Tested
Manually