Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden 'safe-expunging-process' #1135

Closed
TomHennen opened this issue Sep 19, 2024 · 2 comments · Fixed by #1203
Closed

Harden 'safe-expunging-process' #1135

TomHennen opened this issue Sep 19, 2024 · 2 comments · Fixed by #1203
Assignees

Comments

@TomHennen
Copy link
Contributor

In #1094 (comment) @marcelamelara said

I understand the practical reasons for needing to make exceptions in specific edge cases, but I also worry that the safe expunging process may still be worded too broadly. As in, the level of trustworthiness in a source repo at L2 still isn't super high, so what's to stop a rogue/malicious repo admin from abusing the safe expunging exception, especially since there's no documentation requirement? I'm wondering if it might make sense to raise the level at which such exceptions are permitted to make sure certain controls are in place and/or narrow the scope of the safe expunging process.

Let's make sure we're happy with this process before release.

@adityasaky
Copy link
Member

More a follow up question about the current text:

Administrators have the ability to expunge (remove) content from a repository and its change history without leaving a record of the removed content.

I'm trying to understand the "without leaving a record" requirement. Would we have no trace of an object whatsoever? As in, not even its git ID / digest?

@TomHennen
Copy link
Contributor Author

More a follow up question about the current text:

Administrators have the ability to expunge (remove) content from a repository and its change history without leaving a record of the removed content.

I'm trying to understand the "without leaving a record" requirement. Would we have no trace of an object whatsoever? As in, not even its git ID / digest?

I think part of the desire is to not call undue attention to the removal, which might be either especially important given the distributed nature of git (folks may have their own copy that has the removed content) or completely useless given the distributed nature of git (folks can just diff the things). Given the two extremes I think it's hard to actually say and perhaps we should leave that part up to the implementors. Let me make a proposal.

@TomHennen TomHennen self-assigned this Oct 16, 2024
TomHennen added a commit to TomHennen/slsa that referenced this issue Oct 16, 2024
fixes slsa-framework#1135

Hardens the 'safe-expunging-process' by:

1. Suggesting that SCSs should document and log changes when possible.
2. SCSs should use multi-party approval when possible

Also clarifies that some of these changes may need to be kept private
to comply with local laws.

Signed-off-by: Tom Hennen <tomhennen@google.com>
TomHennen added a commit to TomHennen/slsa that referenced this issue Oct 23, 2024
fixes slsa-framework#1135

Hardens the 'safe-expunging-process' by:

1. Suggesting that SCSs should document and log changes when possible.
2. SCSs should use multi-party approval when possible

Also clarifies that some of these changes may need to be kept private
to comply with local laws.

Signed-off-by: Tom Hennen <tomhennen@google.com>
TomHennen added a commit that referenced this issue Oct 25, 2024
fixes #1135

Hardens the 'safe-expunging-process' by:

1. Suggesting that SCSs should document and log changes when possible.
2. SCSs should use multi-party approval when possible

Also clarifies that some of these changes may need to be kept private to
comply with local laws.

---------

Signed-off-by: Tom Hennen <tomhennen@google.com>
Signed-off-by: Tom Hennen <TomHennen@users.noreply.github.com>
Co-authored-by: Zachariah Cox <zachariahcox@github.com>
Co-authored-by: Aditya Sirish <8928778+adityasaky@users.noreply.github.com>
Co-authored-by: Marcela Melara <marcela.melara@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants