Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Contributing guidelines #953

Closed
CircuitSwan opened this issue Aug 21, 2023 · 1 comment · Fixed by #955
Closed

Update Contributing guidelines #953

CircuitSwan opened this issue Aug 21, 2023 · 1 comment · Fixed by #955

Comments

@CircuitSwan
Copy link

Proposed new line 98

The above are loosely enforced during DRAFT periods and up to maintainer discretion. The above are strictly enforced during CANDIDATE periods.

(i don't have ability to propose changes in this repo)

@MarkLodato
@MarkLodato MarkLodato mentioned this issue Aug 22, 2023
Merged
MarkLodato added a commit to MarkLodato/slsa that referenced this issue Aug 22, 2023
@MarkLodato
impl: relax review requirements during Draft stage
41d4979 
As discussed at the 2023-08-21 specification meeting, we do not want to
require a 72h waiting period + 3 reviewers for changes to Draft
specifications, since that will make the iteration speed painfully slow.
Draft specifications are clearly marked as unapproved, and there is
still a Candidate approval process to review the whole spec. Therefore,
change CONTRIBUTING to note that Draft versions are manager discretion
regarding waiting period and number of reviewers.

Fixes slsa-framework#953.

Signed-off-by: Mark Lodato <lodato@google.com>
@MarkLodato
Copy link
Member

Sent out #955.

MarkLodato added a commit that referenced this issue Aug 24, 2023
@MarkLodato
impl: relax review requirements during Draft stage (#955)
8efd98f 
As discussed at the 2023-08-21 specification meeting, we do not want to
require a 72h waiting period + 3 reviewers for changes to Draft
specifications, since that will make the iteration speed painfully slow.
Draft specifications are clearly marked as unapproved, and there is
still a Candidate approval process to review the whole spec. Therefore,
change CONTRIBUTING to note that Draft versions are manager discretion
regarding waiting period and number of reviewers.

Fixes #953.

Signed-off-by: Mark Lodato <lodato@google.com>

---------

Signed-off-by: Mark Lodato <lodato@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Issue triage
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

impl: relax review requirements during Draft stage MarkLodato/slsa
2 participants
@MarkLodato @CircuitSwan