Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: draft: reviewed -> managed #1144

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

TomHennen
Copy link
Contributor

@TomHennen TomHennen commented Sep 20, 2024

The use of a change management tool doesn't necessarily indicate code was reviewed. Perhaps it's simply requiring a PR to be used or a lint checks to be run. 'managed' more precisely gets at what's happening.

fixes #1140

Signed-off-by: Tom Hennen <tomhennen@google.com>
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 4a512f3
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/66ed88b0e255760008af922c
😎 Deploy Preview https://deploy-preview-1144--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TomHennen
Copy link
Contributor Author

Need one more maintainer to approve. Maybe @arewm can help.

@lehors lehors merged commit 8b65d53 into slsa-framework:main Oct 7, 2024
7 checks passed
Copy link
Contributor

@zachariahcox zachariahcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Be more explicit code review?
5 participants