Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: Comment out non critical TODOs #1152

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

lehors
Copy link
Member

@lehors lehors commented Sep 24, 2024

This is the next step into disposing of the TODOs in the threats and mitigation section.
It only leaves in a smaller set of TODOs that really need to be addressed for publication of SLSA 1.1.

The non TODOs are merely commented out so that they can still be considered in the future.

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit b4a8563
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/66f26eab775def00086fc131
😎 Deploy Preview https://deploy-preview-1152--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lehors lehors changed the title Comment out non critical TODOs content: Comment out non critical TODOs Sep 24, 2024
@TomHennen TomHennen requested a review from a team September 24, 2024 13:14
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lehors ! How many critical TODOs are left at this point? They aren't displayed in the diff.

Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lehors
Copy link
Member Author

lehors commented Sep 24, 2024

LGTM, thanks @lehors ! How many critical TODOs are left at this point? They aren't displayed in the diff.

Thanks @marcelamelara. Unfortunately it's not so easy to spot the TODOs that are left. You can see them on the threats and mitigations page of the deploy preview, after selecting the Draft version, if you open all the twisties and search for "TODO". I see 7 of them.
Most of them are about describing how a particular threat is being mitigated. This will take someone with more expertise than I have I'm afraid.

I'm happy to open an issue for each TODO left so that it makes it easier to track.

@lehors lehors merged commit e860657 into slsa-framework:main Oct 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants