Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nonspec: Suggest people assign reviewers to PRs #1154

Merged
merged 6 commits into from
Sep 25, 2024
Merged

nonspec: Suggest people assign reviewers to PRs #1154

merged 6 commits into from
Sep 25, 2024

Commits on Sep 24, 2024

  1. nonspec: Suggest people assign reviewers to PRs 

    Suggest PR authors assign specific reviewers and ping the Slack
channel if they want.

The goal is to make it more clear who is expected to take the next
action on PRs vs the current situation where the maintainers may
think someone else will take a look or that they may have missed
the initial PR request.

fixes slsa-framework#1149

Signed-off-by: Tom Hennen <tomhennen@google.com>
    @TomHennen
    TomHennen committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2fcdbeb View commit details
    Browse the repository at this point in the history

  2. different number of approvals should be sub-bullet 

    Signed-off-by: Tom Hennen <tomhennen@google.com>
    @TomHennen
    TomHennen committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7fb6b7c View commit details
    Browse the repository at this point in the history

  3. link to slack 

    Signed-off-by: Tom Hennen <tomhennen@google.com>
    @TomHennen
    TomHennen committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e27ef42 View commit details
    Browse the repository at this point in the history

  4. Update CONTRIBUTING.md 

    Co-authored-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Tom Hennen <TomHennen@users.noreply.github.com>
    @TomHennen @marcelamelara
    TomHennen and marcelamelara authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    82f3288 View commit details
    Browse the repository at this point in the history

  5. adjust formatting 

    Signed-off-by: Tom Hennen <tomhennen@google.com>
    @TomHennen
    TomHennen committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ac429db View commit details
    Browse the repository at this point in the history

  6. really fix formatting 

    Signed-off-by: Tom Hennen <tomhennen@google.com>
    @TomHennen
    TomHennen committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c8dda83 View commit details
    Browse the repository at this point in the history