Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial: Update statement about compliance with SSDF #1157

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

lehors
Copy link
Member

@lehors lehors commented Sep 27, 2024

Closes #1155.

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 77a24fe
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/66f681dd9a90ad00088cde02
😎 Deploy Preview https://deploy-preview-1157--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arewm
Copy link
Member

arewm commented Sep 27, 2024

nit: Is this more of a nonspec change? Otherwise it would require an addition to the CHANGELOG. https://github.com/slsa-framework/slsa/blob/main/CONTRIBUTING.md#pull-request-types

@lehors
Copy link
Member Author

lehors commented Sep 27, 2024

nit: Is this more of a nonspec change? Otherwise it would require an addition to the CHANGELOG. https://github.com/slsa-framework/slsa/blob/main/CONTRIBUTING.md#pull-request-types

Indeed, I hesitated about the label to use for that matter. It's technically part of the spec but it's really in a non normative part. I don't think our policy is fine-grained enough to differentiate this from other more substantial changes so we're in unchartered territory. I decided to label it as content but I don't think it's worth an entry in the CHANGELOG.

@lehors lehors changed the title content: Update statement about compliance with SSDF editorial: Update statement about compliance with SSDF Sep 30, 2024
@lehors
Copy link
Member Author

lehors commented Sep 30, 2024

On second thought I realized that the right thing to do is to simply label this change as editorial so I updated the title.

@lehors lehors merged commit e9ac733 into slsa-framework:main Sep 30, 2024
8 checks passed
zachariahcox pushed a commit to zachariahcox/slsa that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SSDF is no longer "Forthcoming"
3 participants