Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: draft: Flesh out 'Distribution Channel' threats. #1190

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

TomHennen
Copy link
Contributor

@TomHennen TomHennen commented Oct 14, 2024

These threats generally match the threats for 'Artifact Publication' with
the twist that the consumer must do the verification instead.

Explicitly calling out that modification in transit to the consumer is in scope for this threat.

Consumer verification may be simplified if a VSA was issued at publication time.

fixes #1180

These threats generally match the threats for 'Artifact Publication' with
the twist that the consumer must do the verification instead.

Consumer verification may be simplified if a VSA was issued at publication time.

fixes slsa-framework#1180

Signed-off-by: Tom Hennen <tomhennen@google.com>
Signed-off-by: Tom Hennen <tomhennen@google.com>
Signed-off-by: Tom Hennen <tomhennen@google.com>
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit b57ef0c
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/67110d73a37b830008877274
😎 Deploy Preview https://deploy-preview-1190--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Tom Hennen <tomhennen@google.com>
@TomHennen TomHennen requested a review from lehors October 14, 2024 19:59
Signed-off-by: Tom Hennen <tomhennen@google.com>
TomHennen added a commit to TomHennen/slsa that referenced this pull request Oct 14, 2024
There are two ways to look at the usage threat:

1. Can the attacker modify the software being delivered to a consumer.
2. Can the consumer use the software insecurly allowing an attacker
   to take advantage of that insecurity to exploit them.

IMO 1 has the same solutions as 'G' (PR slsa-framework#1190).  I could repeat them
here under usage, but instead I've updated 'G' to include modification
in transit, and I've had 'Usage' address 2 above (albeit by just
deferring to CISA's work in this area).

fixes slsa-framework#1182

Signed-off-by: Tom Hennen <tomhennen@google.com>
@TomHennen
Copy link
Contributor Author

FWIW I'm considering moving these things to usage and just pointing most of (G) there. Any thoughts welcome.

@TomHennen
Copy link
Contributor Author

FWIW I'm considering moving these things to usage and just pointing most of (G) there. Any thoughts welcome.

I take it back. The 'Usage' section says "A usage threat is a potential for an adversary to exploit behavior of the consumer." Verification would seem to be out of scope.

Signed-off-by: Tom Hennen <tomhennen@google.com>
TomHennen added a commit to TomHennen/slsa that referenced this pull request Oct 17, 2024
There are two ways to look at the usage threat:

1. Can the attacker modify the software being delivered to a consumer.
2. Can the consumer use the software insecurly allowing an attacker
   to take advantage of that insecurity to exploit them.

IMO 1 has the same solutions as 'G' (PR slsa-framework#1190).  I could repeat them
here under usage, but instead I've updated 'G' to include modification
in transit, and I've had 'Usage' address 2 above (albeit by just
deferring to CISA's work in this area).

fixes slsa-framework#1182

Signed-off-by: Tom Hennen <tomhennen@google.com>
Copy link
Member

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Thanks @TomHennen

@TomHennen
Copy link
Contributor Author

Taking into account some review that @zachariahcox did on #1191 I think we're good to go here.

@TomHennen TomHennen merged commit 0c83024 into slsa-framework:main Oct 23, 2024
7 checks passed
TomHennen added a commit that referenced this pull request Oct 23, 2024
There are two ways to look at the usage threat:

1. Can the attacker modify the software being delivered to a consumer.
2. Can the consumer use the software insecurly allowing an attacker
   to take advantage of that insecurity to exploit them.

IMO 1 has the same solutions as 'G' (PR
#1190). I could repeat them
here under usage, but instead I've updated 'G' to include modification
in transit, and I've had 'Usage' address 2 above (albeit by just
deferring to CISA's work in this area).

fixes #1182

NOTE: this PR is based on top of #1190 since the solution presented in
1190 obviates the need for addressing that here.

---------

Signed-off-by: Tom Hennen <tomhennen@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

TODO: Need to fill out threat and mitigation of "(G) Distribution channel"
3 participants