Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nonspec: Make requirements for draft reviews more explicit #1201

Merged
merged 3 commits into from
Oct 24, 2024

Commits on Oct 16, 2024

  1. nonspec: Make requirements for draft reviews more explicit

    Currently CONTRIBUTING.md says that PRs that affect draft
    files have 'relaxed' approval requirements but does not
    specify what those relaxed requirements are.
    
    This PR makes the default requirements for draft PRs explicit
    (only 1 reviewer, no waiting period) in an attempt to speed
    progress on draft changes. Approving reviewers will have
    the opportunity to indicate if they want additional reviewers
    prior to submitting these draft PRs.
    
    We will still have strict requirements (3 approvers, 72h
    waiting period) when moving content from draft to rc or
    final status. This should allow thorough review of changes
    in their finished state without hampering progress on new
    tracks.
    
    Signed-off-by: Tom Hennen <tomhennen@google.com>
    TomHennen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d702547 View commit details
    Browse the repository at this point in the history
  2. just leave it up to the author if they're a maintainer

    Signed-off-by: Tom Hennen <tomhennen@google.com>
    TomHennen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1dace4d View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. add instruction to include 'draft' in PR title

    Signed-off-by: Tom Hennen <tomhennen@google.com>
    TomHennen committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    cb865c6 View commit details
    Browse the repository at this point in the history