Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: draft: clarify "in the present context" #1205

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

TomHennen
Copy link
Contributor

My read is that "the present context" is what branches or tags point at the given revision. Making that explicit.

fixes #1138

My read is that "the present context" is what branches or tags
point at the given revision.  Making that explicit.

fixes slsa-framework#1138

Signed-off-by: Tom Hennen <tomhennen@google.com>
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 149a49e
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/67101253a056730008939de7
😎 Deploy Preview https://deploy-preview-1205--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TomHennen
Copy link
Contributor Author

I'm taking a shot at resolving this issue based on the conversation we've had.

PTAL? I can adjust if this isn't right.

Copy link
Member

@mlieberman85 mlieberman85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomHennen !

@marcelamelara marcelamelara merged commit aae517c into slsa-framework:main Oct 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

What does "exist in the present context" mean?
4 participants