editorial: state predicateType explicitly
#935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
In the top of the Provenance and VSA specification pages, explicitly state the `predicateType` and instruct the reader to use this string rather than the URL. Also move the link to in-toto and the RFC 2119 blurb (if present) up there as well. Motivation: 1. Remove ambiguity, particularly around trailing slashes. 2. Open the path to move provenance and VSA underneath the spec directory, so that everything is versioned together. If that happens, we'll redirect the `predicateType` URI to the latest minor version. Signed-off-by: Mark Lodato <lodato@google.com>
MarkLodato
force-pushed
the
attestation-uri
branch
from
eae58b5
to
07db5fa
Compare
Signed-off-by: Mark Lodato <lodato@google.com>
joshuagl
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the top of the Provenance and VSA specification pages, explicitly
state the
predicateTypeand instruct the reader to use this stringrather than the URL. Also move the link to in-toto and the RFC 2119
blurb (if present) up there as well.
Motivation:
directory, so that everything is versioned together. If that happens,
we'll redirect the
predicateTypeURI to the latest minor version.Signed-off-by: Mark Lodato lodato@google.com