Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial: Fix SLSA level in VSA v1 example #941

Conversation

AdamZWu
Copy link
Contributor

@AdamZWu AdamZWu commented Aug 11, 2023

No description provided.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 826e2a7
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/64de416ffa1a420008ce679d
😎 Deploy Preview https://deploy-preview-941--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AdamZWu AdamZWu changed the title Fix SLSA level in VSA v1 example editorial: Fix SLSA level in VSA v1 example Aug 11, 2023
Copy link
Member

@mlieberman85 mlieberman85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuagl
Copy link
Member

This change LGTM, thanks @AdamZWu! Could you resolve the conflict and add your DCO, per the CONTRIBUTING document?

@AdamZWu AdamZWu closed this Aug 17, 2023
@AdamZWu AdamZWu force-pushed the ZhenyuWu-vsa-v1_0_vsa_level_example_fix branch from c9c97ea to bab0fad Compare August 17, 2023 15:45
Signed-off-by: Zhenyu Wu <zhenyuwu@google.com>
@AdamZWu
Copy link
Contributor Author

AdamZWu commented Aug 17, 2023

Let's see if I fixed this. 😄

@AdamZWu AdamZWu reopened this Aug 17, 2023
@MarkLodato MarkLodato merged commit 2d1b1d2 into slsa-framework:main Aug 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants