impl: add fix PR tag and explain purpose of tags
#952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new `fix` PR tag for typos, broken links, and similar. Previously these were categorized as `editorial`, but that sounded too significant and required two maintainers to approve plus 24 hours wait. The new `fix` category is treated the same as `impl`, requiring only one approval and no wait time. Also: - Add a paragraph explaining the purpose of the PR tag. - Rephrase the preface to the table to provide more clear instructions. - Create a section heading for the table now that the size of the section has grown. Signed-off-by: Mark Lodato <lodato@google.com>
✅ Deploy Preview for slsa canceled.
|
MarkLodato
changed the title
fix tag, explain purposefix PR tag and explain purpose of tags
joshuagl
approved these changes
Aug 21, 2023
arewm
reviewed
Aug 21, 2023
arewm
approved these changes
Aug 21, 2023
|
Since GitHub doesn't allow for stacked PRs, I'll submit this now so that I can send out the follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
fixPR tag for typos, broken links, and similar. Previouslythese were categorized as
editorial, but that sounded toosignificant and required two maintainers to approve plus 24 hours wait.
The new
fixcategory is treated the same asimpl, requiring only oneapproval and no wait time.
Also:
section has grown.
Signed-off-by: Mark Lodato lodato@google.com