impl: relax review requirements during Draft stage #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed at the 2023-08-21 specification meeting, we do not want to require a 72h waiting period + 3 reviewers for changes to Draft specifications, since that will make the iteration speed painfully slow. Draft specifications are clearly marked as unapproved, and there is still a Candidate approval process to review the whole spec. Therefore, change CONTRIBUTING to note that Draft versions are manager discretion regarding waiting period and number of reviewers. Fixes slsa-framework#953. Signed-off-by: Mark Lodato <lodato@google.com>
✅ Deploy Preview for slsa canceled.
|
joshuagl
approved these changes
Aug 22, 2023
arewm
reviewed
Aug 22, 2023
Signed-off-by: Mark Lodato <lodato@google.com>
arewm
approved these changes
Aug 22, 2023
Signed-off-by: Mark Lodato <lodato@google.com>
arewm
approved these changes
Aug 22, 2023
|
I'll submit now, but if you have any suggestions, comment here and I'll fix in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at the 2023-08-21 specification meeting, we do not want to
require a 72h waiting period + 3 reviewers for changes to Draft
specifications, since that will make the iteration speed painfully slow.
Draft specifications are clearly marked as unapproved, and there is
still a Candidate approval process to review the whole spec. Therefore,
change CONTRIBUTING to note that Draft versions are manager discretion
regarding waiting period and number of reviewers.
Fixes #953.
Signed-off-by: Mark Lodato lodato@google.com