Clarify meaning of signer as per confusion in slack #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoleSchwartz
requested review from
MarkLodato,
mlieberman85 and
joshuagl
as code owners
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| can sign provenance for the "GitHub Actions" builder, and "Google" can sign | ||
| provenance for the "Google Cloud Build" builder, but "GitHub" cannot sign for | ||
| the "Google Cloud Build" builder. | ||
| Consumers MUST accept only specific signer-builder pairs. The signer is the public key identity, |
There was a problem hiding this comment.
Do we want to clarify that it can be the public key identity or identity provider?
|
@NicoleSchwartz Do you plan to pick this up? If not, let's close. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per slack https://openssf.slack.com/archives/C029E4N3DPF/p1695916703852369 conversation trying to clarify signer