Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify meaning of signer as per confusion in slack #972

Closed
wants to merge 1 commit into from
Closed

Clarify meaning of signer as per confusion in slack #972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions docs/spec/v1.0/provenance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,10 +380,11 @@ identity because it's all GitHub from the consumer's perspective. Meanwhile,
each self-hosted runner might have its own identity because not all runners are
trusted by all consumers.

Consumers MUST accept only specific signer-builder pairs. For example, "GitHub"
can sign provenance for the "GitHub Actions" builder, and "Google" can sign
provenance for the "Google Cloud Build" builder, but "GitHub" cannot sign for
the "Google Cloud Build" builder.
Consumers MUST accept only specific signer-builder pairs. The signer is the public key identity,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to clarify that it can be the public key identity or identity provider?

and the builder is the builder.id. For example, "GitHub" can sign provenance
for the "GitHub Actions" builder, and "Google" can sign provenance for the
"Google Cloud Build" builder, but "GitHub" cannot sign for the
"Google Cloud Build" builder.

Design rationale: The builder is distinct from the signer in order to support
the case where one signer generates attestations for more than one builder, as
Expand Down
Loading