content: recommend a VSA include the policy's digest #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MarkLodato
approved these changes
Oct 10, 2023
Thanks! That matches my mental model (I was surprised when working on this change that the policy was required). I agree, this change still works with that change (tracked as part of #878 but should probably be a separate issue). |
lehors
reviewed
Oct 12, 2023
kpk47
approved these changes
Oct 12, 2023
lehors
approved these changes
Oct 13, 2023
arewm
requested changes
Oct 13, 2023
MarkLodato
approved these changes
Oct 16, 2023
Recommended that the `digest` field of `ResourceDescriptor` is set in a Verification Summary Attestation's (VSA) `policy` object. Signed-off-by: Joshua Lock <joshuagloe@gmail.com>
Signed-off-by: Joshua Lock <joshuagloe@gmail.com>
joshuagl
force-pushed
the
joshuagl/vsa-recommend-policy-digest
branch
from
9106849
to
f41a8d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended that the
digestfield ofResourceDescriptoris set in a Verification Summary Attestation's (VSA)policyobject.Fixes: #803