Designed the landing page #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaranjitghose
approved these changes
Oct 16, 2020
app.py
Outdated
| @@ -46,56 +45,71 @@ def main(): | |||
|
|
|||
| if choice == "Home": | |||
There was a problem hiding this comment.
By default Home should be the first thing we visit when the app loads as well as in the Menu Bar on the left
There was a problem hiding this comment.
Then what change should be done?
There was a problem hiding this comment.
The first if statement should be for Home Page
app.py
Outdated
| st.image(img) | ||
| st.image([covid_img,diabetic_img,heart_img,pneu_img,skin_img],caption=["COVID-19 Detection","Diabetic Retinopathy","Heart Disease Prediction","Pneumonia Detection","Skin Cancer Detection"]) | ||
| st.write("Illustration of the Web Application:") | ||
| st.video('assets/demo.mp4') |
There was a problem hiding this comment.
Can you please put a small recording of the app with this change in the description of this Pull Request
app.py
Outdated
| st.video('assets/demo.mp4') | ||
|
|
||
| # below is the sample function you need to implement in separate python file | ||
|
|
There was a problem hiding this comment.
Simply remove the code. If required we can define it in another script and import it
|
I have done the required changes, could you please review? |
smaranjitghose
approved these changes
Oct 17, 2020
|
give @SoniGarima 150 points |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is for issue #57
I have added the following: