Implement Sorting and Filtering of Changes based on Branches #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- shows a list of branches on the left and right side - allows to search for branches - allows to sort branches by most used, most recent, or alphabetically Signed-off-by: Stefan Marr <git@stefan-marr.de>
- adapt naming to match the implementation - sort vs filter, cards-container vs list - added added type to get better tool feedback - refactor code to: - only request data once from the server - process branch details only once - eliminate redundant code to add changes to the changes lists (with and without filtering) - break things up into more functions - use .data() function to access the triggered element and avoid having to create new closures for each element Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
changed the title
smarr
changed the title
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #211.
It provides a list of branches that can be sorted by:
Selecting a branch filters the changes.
The list of branches itself can be filter by a search field, too.