Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Version Tag for CSS File #216

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Add Version Tag for CSS File #216

merged 4 commits into from
Jul 30, 2024

Conversation

smarr
Copy link
Owner

@smarr smarr commented Jul 26, 2024

CSS files are cached aggressively. By adding a version tag, we can control more actively that we want to retrieve a new version from the server.

@F12-Syntex would be great if you could review this one on Monday.

Thanks!

smarr added 4 commits July 26, 2024 22:20
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Use a version string that is specific to tests and stable.

Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr smarr added the enhancement New feature or request label Jul 26, 2024
Copy link

@F12-Syntex F12-Syntex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nothing major or too difficult to understand, minimal and seems to do the job

@smarr
Copy link
Owner Author

smarr commented Jul 30, 2024

Thanks

@smarr smarr merged commit 1f9c62b into master Jul 30, 2024
2 checks passed
@smarr smarr deleted the version-tag-for-css branch July 30, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants