-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sass/rename particle functions #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of the functionality in HelperFunctions could be done using pytest functionalities. Also, the CHANGELOG entry is missing.
We should be careful with changing the name of functions in Particle.
These are just some thoughts coming to my mind after seeing the comment of your PR. Haven't had time to look at the code and the new names yet. |
Absolutely, the Changelog needs of course to be adjusted, this I will add. |
@NGoetz this PR is ready for a second review |
@Hendrik1704 @NGoetz Once Niklas reviewed the PR, please, do not yet merge it. I am just modifying the open PR #264 as I realized how many code duplications we have in Filters.py. I am just cleaning it up and I think it will be more efficient to first merge #264 once it is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
798dc41
to
6445283
Compare
In this PR I do two things:
1. Renaming Member Functions
In Particle we have chosen function names that are suboptimal and not intuitive to find or they contained parts in their name that do not contain any useful information. I have renamed them to make them more precise and easier to find. They are:
2. Introducing Helper Functions
In tests/test_JetAnalysis.py we were comparing two nested lists using
However, this fails on different machines because of numerical precision when comparing floats. I have introduced a new file tests/HelperFunctions.py that contains a function to compare two lists taking into account the limits of numerical precision. This function is now used