Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact isn't built from the released version #46

Open
apryce opened this issue Jan 27, 2016 · 0 comments
Open

Artifact isn't built from the released version #46

apryce opened this issue Jan 27, 2016 · 0 comments

Comments

@apryce
Copy link

apryce commented Jan 27, 2016

The artifact used is based off the starting commit, not the released commit.
For instance if you are releasing 1.1.0 and have a file that uses the "replace" grunt plugin to copy in the version, it will copy the '1.1.0-SNAPSHOT' from the package.json. The build is run before the version is bumped.

The following (line 124 of maven_tasks.js at time of writing) shows the relevant part of the code.

 grunt.task.run(
      'maven:version:' + options.version,
      'mvn:package',
      'maven:deploy-file',
      'maven:version:' + options.nextVersion + ':deleteTag'
    );

What I think needs to happen is an option, say buildTask, for a grunt task to be run after the first maven:version, but before the mvn:package. Then I could set buildTask to 'build' (which is currently run before the grunt-maven-tasks maven:release task) and have the build actually be against the correct version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant