Only honour removal of fullscreen state if the state is currently present #311
+39
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for the ewmh hook that handles changes to full screen state was unconditionally honouring requests to remove full screen state even when the client in question was not currently full screen. This lead to clients losing their floating position within the window manager state as we
sinkthe client in question as part of this due to our full screen implementation simply being to mark the client as floating above all other windows and setting it to the size of the physical screen.As part of debugging this issue this PR also improves logging in a number of places as well as adjusting logging levels so that the
debuglevel is less verbose.Closes #310