feat: add SimpleBlob TestModel for Rust #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbanchich
force-pushed
the
andrewbanchich/simpleblob
branch
from
4997cbb
to
925daef
Compare
MikaelMayer
reviewed
May 8, 2024
TestModels/SimpleTypes/SimpleBlob/runtimes/rust/dafny_impl/src/implementation_from_dafny.rs
Outdated
Show resolved
Hide resolved
andrewbanchich
force-pushed
the
andrewbanchich/simpleblob
branch
2 times, most recently
from
fa72165
to
b2aaa32
Compare
robin-aws
requested changes
May 9, 2024
TestModels/SimpleTypes/SimpleBlob/runtimes/rust/src/operation/get_blob/_get_blob_input.rs
Outdated
Show resolved
Hide resolved
TestModels/SimpleTypes/SimpleBlob/runtimes/rust/tests/simple_blob_test.rs
Outdated
Show resolved
Hide resolved
robin-aws
reviewed
May 13, 2024
TestModels/SimpleTypes/SimpleBlob/runtimes/rust/src/operation/get_blob/_get_blob_input.rs
Show resolved
Hide resolved
robin-aws
previously approved these changes
May 16, 2024
| dafny_value.value().Extract().to_array(), | ||
| )) | ||
| Some( | ||
| ::std::rc::Rc::try_unwrap(dafny_value.value().Extract().to_array()) |
There was a problem hiding this comment.
This looks like the right approach AFAICT. I'm not 100% sure it's the best we can do in the limit, but I am sure that it's much easier to optimize this kind of thing once we're actually generating the code, so it should be very quick to fix if we do realize we can do better latter. E.g. we may want to add this conversion to the Dafny Rust runtime.
|
Please import the generated file and I can help you generate the future files after #368 (need to install Dafny locally, on the branch feat-rust, and then run |
added 11 commits
May 20, 2024 15:41
andrewbanchich
force-pushed
the
andrewbanchich/simpleblob
branch
from
93252f8
to
9f41c1b
Compare
added 2 commits
May 21, 2024 15:51
robin-aws
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
adds
SimpleBlobtest modelBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.