Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use commit from Dafny feature branch for testing Rust support #368

Merged
merged 32 commits into from
May 22, 2024

Conversation

MikaelMayer
Copy link
Collaborator

@MikaelMayer MikaelMayer commented May 16, 2024

I updated the generated rust code using the branch feat-rust of Dafny.

...And I (a.k.a. @robin-aws) modified the various Makefile targets to use this branch in order to eliminate (almost) all of the patching to Dafny-generated code.

Notable features:

  • Reference-counting changes a bit the macros that were necessary.
  • TestsModels/dafny-dependencies/StandardLibrary, TestsModels/SimpleType/SimpleString, and TestsModels/SimpleType/SimpleBoolean (@robin-aws: and SimpleBlob!) can now be automatically generated using the command line DAFNY=<path to dafny.exe on branch feat-rust> make dafny_benerate make transpile_rust as usual (I added Mikael's bit of post-processing to the existing target instead)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@MikaelMayer MikaelMayer requested a review from a team as a code owner May 16, 2024 16:26
@MikaelMayer MikaelMayer mentioned this pull request May 16, 2024
@MikaelMayer MikaelMayer requested a review from seebees May 16, 2024 16:27
…obin-aws/test-rust-with-dafny-feat-rust-branch

# Conflicts:
#	.github/workflows/pull.yml
#	.github/workflows/push.yml
…obin-aws/test-rust-with-dafny-feat-rust-branch
…atest-dafny-rust

# Conflicts:
#	TestModels/SimpleTypes/SimpleBlob/runtimes/rust/dafny_impl/src/implementation_from_dafny.rs
#	TestModels/SimpleTypes/SimpleString/codegen-patches/rust/dafny-4.5.0.patch
…atest-dafny-rust

# Conflicts:
#	TestModels/SimpleTypes/SimpleString/codegen-patches/rust/dafny-4.5.0.patch
@robin-aws robin-aws changed the title Latest dafny rust ci: Use commit from Dafny feature branch for testing Rust support May 22, 2024
@robin-aws robin-aws merged commit fe59c24 into main-1.x May 22, 2024
132 checks passed
@robin-aws robin-aws deleted the latest-dafny-rust branch May 22, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants