Request Compression #144
Merged
Request Compression #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextwoods
reviewed
Jul 12, 2023
codegen/smithy-ruby-codegen-test/model/component-test/compression.smithy
Outdated
Show resolved
Hide resolved
codegen/smithy-ruby-codegen-test/model/component-test/compression.smithy
Show resolved
Hide resolved
|
I'm failing the Hearth CI / rubocop check since line 20 on request_compression.rb is just two characters extra long. I don't think I can change the config names as it is strictly outlined in the Smithy Docs. Am I able to exclude this specific file under rubocop's Layout/LineLength? LMK your thoughts. Thanks in advance for looking into the structure! 😄 |
|
You can either rename the internal variable to be shorter or split the line after = |
mullermp
reviewed
Jul 12, 2023
codegen/smithy-ruby-codegen-test/model/component-test/compression.smithy
Outdated
Show resolved
Hide resolved
...degen/src/main/java/software/amazon/smithy/ruby/codegen/integrations/RequestCompression.java
Outdated
Show resolved
Hide resolved
alextwoods
approved these changes
Jul 21, 2023
...tware/amazon/smithy/ruby/codegen/test/protocol/fakeprotocol/generators/BuilderGenerator.java
Show resolved
Hide resolved
mullermp
approved these changes
Jul 21, 2023
codegen/smithy-ruby-codegen-test/integration-specs/compression_spec.rb
Outdated
Show resolved
Hide resolved
mullermp
added a commit
that referenced
this pull request
Jul 24, 2023
commit 976e262 Author: Juli Tera <57973151+jterapin@users.noreply.github.com> Date: Fri Jul 21 19:06:23 2023 -0400 Add Request Compression support (#144) commit 289f04c Author: Alex Woods <alexwoo@amazon.com> Date: Thu Jul 20 11:25:26 2023 -0700 Fix bug in RubyDirectedCodegen that causes errors module to not be generated when no modeled errors on model. commit 8573788 Author: Alex Woods <alexwoo@amazon.com> Date: Tue Jul 18 10:18:54 2023 -0700 Cleanup rails-json httpPayloadMember commit 7309629 Author: Matt Muller <53055821+mullermp@users.noreply.github.com> Date: Mon Jul 17 13:18:00 2023 -0400 Add validation to Config and Params (#145)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Implementing Compression middleware - a middleware that compresses the request body and adds the
Content-EncodingheaderBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.