Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CI with Rubocop #147

Merged
merged 17 commits into from
Jul 25, 2023
Merged

Upgrade CI with Rubocop #147

merged 17 commits into from
Jul 25, 2023

Conversation

jterapin
Copy link
Contributor

Description of changes:

  • Updated CI to include rubocop task for codegen directory
  • Added rubocop yml file
  • Fixed rubocop offenses in codegen

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

alextwoods
alextwoods reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

codegen/.rubocop.yml Outdated Show resolved Hide resolved
codegen/.rubocop.yml Outdated Show resolved Hide resolved
mullermp
mullermp reviewed Jul 24, 2023
View reviewed changes
codegen/.rubocop.yml Show resolved Hide resolved
.github/workflows/codegen_ci.yml Show resolved Hide resolved
mullermp
mullermp reviewed Jul 24, 2023
View reviewed changes
codegen/.rubocop.yml Outdated Show resolved Hide resolved
@jterapin
Copy link
Contributor Author

Based on our group discussion yesterday, I made the following changes:

  • Codegen's rubocop file will inherit base configuration files from hearth's .rubocop.yml via using the inherit_from
  • Updated Hearth's .rubocop.yml file relating to Gemspec/MFA so it can be inherited
  • Still bringing over Hearth's Gemfile (and its dependencies) to run the rubocop in codegen (ensuring consistency in rubocop versions if we decide to specify)

Thanks for looking this throughly, team!

@jterapin jterapin marked this pull request as ready for review July 25, 2023 16:18
alextwoods
alextwoods approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jterapin jterapin merged commit 710f1c3 into main Jul 25, 2023
17 checks passed
@jterapin jterapin deleted the upgrade_CI branch July 25, 2023 19:43
mullermp added a commit that referenced this pull request Jul 25, 2023
@mullermp
Squashed commit of the following:
11636dd 
commit 5a712d3
Author: Alex Woods <alexwoo@amazon.com>
Date:   Tue Jul 25 13:47:04 2023 -0700

    Fix stub prefix headers + float validation

commit 710f1c3
Author: Juli Tera <57973151+jterapin@users.noreply.github.com>
Date:   Tue Jul 25 15:37:49 2023 -0400

    Upgrade CI with Rubocop (#147)
mullermp added a commit that referenced this pull request Jul 25, 2023
@mullermp
Squashed commit of the following:
e900413 
commit a30fa26
Author: Alex Woods <alexwoo@amazon.com>
Date:   Tue Jul 25 14:21:42 2023 -0700

    Update params to use to_f for float/double (ensure correct types)

commit 5a712d3
Author: Alex Woods <alexwoo@amazon.com>
Date:   Tue Jul 25 13:47:04 2023 -0700

    Fix stub prefix headers + float validation

commit 710f1c3
Author: Juli Tera <57973151+jterapin@users.noreply.github.com>
Date:   Tue Jul 25 15:37:49 2023 -0400

    Upgrade CI with Rubocop (#147)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextwoods alextwoods alextwoods approved these changes

@mullermp mullermp mullermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jterapin @mullermp @alextwoods