Codegen Output Demo - Config Constraints #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextwoods
reviewed
Jul 27, 2023
| @@ -128,6 +128,13 @@ def validate_types! | |||
| Hearth::Validator.validate_types!(validate_input, TrueClass, FalseClass, context: 'config[:validate_input]') | |||
| end | |||
|
|
|||
| def validate_range! | |||
There was a problem hiding this comment.
I think I might argue for changing the name of the validate_types! method to be just validate! (requires changing Hearth::Configuration) and then adding the validations for each member together. Eg:
validate_type(config_1)
validate_range(config_1)
some_other_future_validation(config_1)
validate_type(config_2)
validate_tyupe(config_3)
|
|
||
| # draft of what validate_range *could* look like | ||
| # valid_range param consists of min and max keys | ||
| def self.validate_range(value, valid_range, context:) |
There was a problem hiding this comment.
What about using kwargs for min and max?
self.validate_range(value, min:, max:, context:)
Makes it easy to use like:
validate_range(value, min: 0, max: 10000)
There was a problem hiding this comment.
Ahh, yes. That would make sure we have :min and :max passed in.
| def self.validate_range(value, valid_range, context:) | ||
| # need to validate the valid_range object before proceeding | ||
| # does it make sense us to use existing method - validate_type! | ||
| valid_range.each { |context, value| self.validate_type!(value, Integer, context: context) } |
There was a problem hiding this comment.
I think we can probably skip validating that the inputs for min/max are correct since these aren't intended as customer input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Before I dive into the design/implementation work, I wanted to visualize what the end result could look like in Hearth and the
config.rbfile in the projected service.In this possible implementation, I'm thinking of adding a
validate_rangemethod to the Hearth'sValidatormodulePlease ignore the inconsistency of naming as this is just a rough draft.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.