Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identity and Auth #154

Merged
merged 21 commits into from
Aug 18, 2023
Merged

Identity and Auth #154

merged 21 commits into from
Aug 18, 2023

Conversation

mullermp
Copy link
Contributor

@mullermp mullermp commented Aug 2, 2023 •
edited
Loading

Done:

  • Identity classes
  • Auth schemes
  • Auth option and auth resolver
  • Refreshing identity resolver module
  • Basic and refreshing identity resolver class
  • Auth middleware
  • Auth / white label integration specs
  • Identity specs
  • Refreshing identity module specs
  • Basic identity resolver spec
  • Auth schemes specs
  • Auth option specs
  • Auth middleware spec

Signers and signing auth will be done in a different PR?

@alextwoods alextwoods marked this pull request as draft August 2, 2023 18:30
@mullermp mullermp marked this pull request as ready for review August 4, 2023 21:04
@mullermp mullermp marked this pull request as draft August 4, 2023 21:04
@mullermp mullermp marked this pull request as ready for review August 16, 2023 21:26
alextwoods
alextwoods reviewed Aug 17, 2023
View reviewed changes
codegen/smithy-ruby-codegen-test/integration-specs/auth_spec.rb Show resolved Hide resolved
codegen/smithy-ruby-codegen-test/integration-specs/auth_spec.rb Outdated Show resolved Hide resolved
codegen/smithy-ruby-codegen/build.gradle.kts Show resolved Hide resolved
...egen/src/main/java/software/amazon/smithy/ruby/codegen/generators/AuthResolverGenerator.java Show resolved Hide resolved
...egen/src/main/java/software/amazon/smithy/ruby/codegen/generators/AuthResolverGenerator.java Show resolved Hide resolved
hearth/lib/hearth/auth_schemes.rb Outdated Show resolved Hide resolved
hearth/lib/hearth/auth_schemes.rb Show resolved Hide resolved
hearth/lib/hearth/middleware/sign.rb Show resolved Hide resolved
hearth/lib/hearth/refreshing_identity.rb Outdated Show resolved Hide resolved
hearth/lib/hearth/refreshing_identity_resolver.rb Outdated Show resolved Hide resolved
alextwoods
alextwoods approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - LGTM!

hearth/spec/hearth/refreshing_identity_resolver_spec.rb Show resolved Hide resolved
@mullermp mullermp merged commit d692df2 into main Aug 18, 2023
11 checks passed
@mullermp mullermp deleted the sra-identity branch August 18, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextwoods alextwoods alextwoods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mullermp @alextwoods