Update relative middleware support #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextwoods
reviewed
Aug 28, 2023
codegen/smithy-ruby-codegen-test-utils/middleware/test_middleware.rb
Outdated
Show resolved
Hide resolved
codegen/smithy-ruby-codegen-test/integration-specs/relative_middleware_spec.rb
Show resolved
Hide resolved
...-codegen/src/main/java/software/amazon/smithy/ruby/codegen/middleware/MiddlewareBuilder.java
Outdated
Show resolved
Hide resolved
mullermp
reviewed
Aug 29, 2023
codegen/projections/white_label/spec/relative_middleware_spec.rb
Outdated
Show resolved
Hide resolved
codegen/smithy-ruby-codegen-test/model/component-test/compression.smithy
Show resolved
Hide resolved
...are/amazon/smithy/ruby/codegen/middleware/factories/RequestCompressionMiddlewareFactory.java
Show resolved
Hide resolved
codegen/smithy-ruby-codegen-test-utils/middleware/test_middleware.rb
Outdated
Show resolved
Hide resolved
mullermp
approved these changes
Aug 30, 2023
codegen/smithy-ruby-codegen-test/model/component-test/relative.smithy
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Current implementation of the Relative middleware raises an error when a middleware specifies a Relative that does not exist. The behavior that we want to adjust is that if that Relative is not a required middleware, the middleware stack ordering should proceed as normal. This PR will address this modification.
In addition to the above, the following has been added/revised:
CodegenExceptionto cover cases when a streaming body has ahttpChecksumRequiredtraitFINALIZEstep toSIGNto match with Hearth.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.